Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Authn pages - fix background on medium resolutions [quince] #1193

Open
wants to merge 1 commit into
base: open-release/quince.master
Choose a base branch
from

Conversation

Lunyachek
Copy link
Contributor

This is backport from master branch - #1192

Description

At some resolutions, we can see this bug. It's related to the SVG image having a specific height, and at certain page sizes, this height isn't enough for the SVG to reach the bottom of the page. We suggest drawing a slanted background using CSS

How Has This Been Tested?

Locally, in different browsers and resolutions (Screenshots below)

Before
Снимок экрана 2024-03-05 в 15 59 26

After
Снимок экрана 2024-03-05 в 16 04 56

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 5, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Mar 5, 2024
@zainab-amir zainab-amir added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Status: Backlog
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

4 participants